feat: expose tls info on responses optionally - #144
Open
arishgithub wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
Hello @0x676e67 , please review. |
arishgithub
force-pushed
the
expose-tls-info-on-responses
branch
from
July 28, 2026 15:03
f1e5c87 to
62aff70
Compare
Collaborator
|
@arishgithub Please follow the review feedback; otherwise this PR will be closed. We enforce strict code quality standards. |
Contributor
Author
|
@0x676e67 can you give a couple of points which can be done better here? so that I can understand how to refactor this. Would be helpful in understanding how to approach this exactly. Thanks |
Contributor
Author
|
@0x676e67 i have made some changes as per what I could understand from 'overly fragmented code' review feedback. Please let me know if this is not enough or incorrect, and point me to the right understanding if possible. |
Collaborator
|
There are no major issues for the time being; I will make some appropriate code style adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #125